Skip to content
This repository was archived by the owner on Aug 9, 2023. It is now read-only.

Add support for Vue #15

Closed
wants to merge 11 commits into from
Closed

Add support for Vue #15

wants to merge 11 commits into from

Conversation

medfreeman
Copy link
Contributor

@medfreeman medfreeman commented Sep 4, 2018 •
edited
Loading

🚀
closes #7

wooorm
wooorm suggested changes Sep 6, 2018
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! Here’s some initial questions and suggestions!

@wooorm
Copy link
Member

wooorm commented Nov 8, 2018

@medfreeman I didn’t get a message for those last pushes. Do you think this is ready now?

@medfreeman
Copy link
Contributor Author

@wooorm I think tests need a bit of work to complete the feature, also have to resolve issues in remark-vue to make sure i handle this the proper way.
I'll take time to finish this until sunday, and probably ask you one or two questions in the meantime.
Thanks !

@wooorm
Copy link
Member

wooorm commented Nov 8, 2018

Awesome, and please do!

@wooorm
Copy link
Member

wooorm commented Jan 8, 2019

@medfreeman Ping!

@RageYL
Copy link

RageYL commented Mar 8, 2019

Hi,

What's the status of this PR ? what's left to do ? If the work is not too much I may try to finish it.

I did something similar for my project that handle only the few attributes that i use. Except for one little detail, using this PR seemed to work.

@wooorm wooorm mentioned this pull request Apr 21, 2019
Merged
@wooorm wooorm closed this in #17 Apr 25, 2019
wooorm added a commit that referenced this pull request Apr 25, 2019
@wooorm @medfreeman
Add support for Vue
9ba30f0 
Closes GH-7.
Closes GH-15.
Closes GH-17.

Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>

Co-authored-by: Mehdi Lahlou <mehdi.lahlou@free.fr>
@wooorm wooorm changed the title Add support for Vue.createElement specificities Add support for Vue Aug 11, 2019
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wooorm wooorm wooorm requested changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Vue
3 participants
@medfreeman @wooorm @RageYL