Skip to content

documentation(929925):Revamped dialog and how to topic #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 21, 2025

Conversation

JamunaSundaramSF3699
Copy link
Contributor

No description provided.

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: FAILURE ❌
Source Compilation: SUCCESS ✅
Failure Reason: CI Failure with violation
Build Location: 929925-dialog
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 1
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: FAILURE ❌
Source Compilation: SUCCESS ✅
Failure Reason: CI Failure with violation
Build Location: 929925-dialog
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 1
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@Syncfusion-CI
Copy link

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@Syncfusion-CI
Copy link

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

Build Status: INQUEUE 🕒
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: FAILURE ❌
Source Compilation: Not Started ❌
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INQUEUE 🕒
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

Build Status: INQUEUE 🕒
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit.

@SyncfusionBuild
Copy link
Collaborator

CI Status: ABORTED ❌
Source Compilation: Not Started ❌
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

alert('Add/Edit dialog custom footer button clicked');
}
</script>
<style>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimize this css code

},
args.form.elements.namedItem('ShipCountry')
);
var numeric = new ej.inputs.NumericTextBox({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable name is not meaningful

}
};
function validate() {
var valid = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isValid is proper variable name

@@ -0,0 +1,59 @@
@{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

md file name is not proper change it hierarchyprint-otherpage it is not fine

@@ -0,0 +1,59 @@
@{
var SecondChildGrid = new Syncfusion.EJ2.Grids.Grid() { DataSource = (IEnumerable<object>)ViewBag.CustomerDataSource,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this line variable name must be start in smaller case

@@ -1,22 +1,19 @@

@Html.EJS().Grid("Grid").DataSource((IEnumerable<object>)ViewBag.DataSource).Columns(col =>
@Html.EJS().Grid("grid").DataSource((IEnumerable<object>)ViewBag.DataSource).Height("348px").Columns(col =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this md file name also not proper

Copy link
Collaborator

@MaithiliyK MaithiliyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address my review comments

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit.

@SyncfusionBuild
Copy link
Collaborator

CI Status: ABORTED ❌
Source Compilation: FAILURE ❌
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

Build Status: INPROGRESS 🔃
Build Location: 929925-dialog

@SyncfusionBuild
Copy link
Collaborator

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: 929925-dialog
Technical Error(s): 0
Spelling Error(s): 0
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0
MD Tag Validation Error(s): 0

Copy link
Collaborator

@MaithiliyK MaithiliyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine

@MaithiliyK MaithiliyK merged commit 15465d2 into hotfix/hotfix-v28.1.33 Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants