-
Notifications
You must be signed in to change notification settings - Fork 33
documentation(929925):Revamped dialog and how to topic #3747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: FAILURE ❌ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INQUEUE 🕒 |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit. |
CI Status: ABORTED ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
alert('Add/Edit dialog custom footer button clicked'); | ||
} | ||
</script> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optimize this css code
}, | ||
args.form.elements.namedItem('ShipCountry') | ||
); | ||
var numeric = new ej.inputs.NumericTextBox({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable name is not meaningful
} | ||
}; | ||
function validate() { | ||
var valid = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isValid is proper variable name
@@ -0,0 +1,59 @@ | |||
@{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
md file name is not proper change it hierarchyprint-otherpage it is not fine
@@ -0,0 +1,59 @@ | |||
@{ | |||
var SecondChildGrid = new Syncfusion.EJ2.Grids.Grid() { DataSource = (IEnumerable<object>)ViewBag.CustomerDataSource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this line variable name must be start in smaller case
@@ -1,22 +1,19 @@ | |||
|
|||
@Html.EJS().Grid("Grid").DataSource((IEnumerable<object>)ViewBag.DataSource).Columns(col => | |||
@Html.EJS().Grid("grid").DataSource((IEnumerable<object>)ViewBag.DataSource).Height("348px").Columns(col => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this md file name also not proper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address my review comments
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
Build Status: INPROGRESS 🔃 |
The running CI Job is terminated due to changes committed on the source branch for this Merge Request and CI triggered for latest commit. |
CI Status: ABORTED ❌ |
Build Status: INPROGRESS 🔃 |
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are fine
No description provided.