Skip to content

Remove duplicate addPlugin test case #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Aug 4, 2017

This PR removes a duplicate test case in WebpackConfig.js:

@Lyrkan Lyrkan force-pushed the remove-duplicate-test-case branch from 6f4e9ac to 1ca7dff Compare August 5, 2017 12:22
@weaverryan
Copy link
Member

We were just being extra careful ;). Good catch and thank you!

@weaverryan weaverryan merged commit 1ca7dff into symfony:master Aug 5, 2017
weaverryan added a commit that referenced this pull request Aug 5, 2017
This PR was merged into the master branch.

Discussion
----------

Remove duplicate addPlugin test case

This PR removes a duplicate test case in `WebpackConfig.js`:

* [first instance](https://github.com/symfony/webpack-encore/blob/v0.12.0/test/WebpackConfig.js#L335-L346)
* [second instance](https://github.com/symfony/webpack-encore/blob/v0.12.0/test/WebpackConfig.js#L368-L379)

Commits
-------

1ca7dff Remove duplicate addPlugin test case
@Lyrkan Lyrkan deleted the remove-duplicate-test-case branch August 5, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants