Warning when manifest key prefix starts with "/" #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
tighter-manifest-key-prefix
branch
from
d67f0ab to
38516d0
Compare
weaverryan
changed the title
weaverryan
force-pushed
the
tighter-manifest-key-prefix
branch
from
1ac0df2 to
baa70b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is allowed, and will still be allowed. But after this PR, you will get a warning.
This is to help people from "tripping up" and accidentally changing their manifest key prefix from
public/to/public/when callingsetManifestKeyPrefix(). I thought this might cause issues, and it did in #96 - #96 (comment)Cheers!