Skip to content

Fix missing tsloader return statement #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ldiringer
Copy link
Contributor

This commit (35d9e6f#diff-168726dbe96b3ce427e7fedce31bb0bc) removed inadvertently the return this; statement from the enableTypeScriptLoader function.

This prevents calling another function chained on enableTypeScriptLoader in a webpack.config.js file.

This PR just puts the return this; statement back.

@davidmpaz
Copy link
Contributor

We should definitely make a test for the pubic API, to prevents such cases in future. Do you think you could add some @ldiringer ?

@davidmpaz
Copy link
Contributor

what do you think if api.js file get renamed to index.js, that way it explicitly says what part is testing?

tests look great!. Thank you very much, i hope this get merged soon.

@ldiringer
Copy link
Contributor Author

All done. Thank you for the review @davidmpaz!

@weaverryan
Copy link
Member

Thank you @ldiringer.

@weaverryan
Copy link
Member

And thank you also for the test - that was very clearly needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants