Skip to content

Update Vue docs #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Update Vue docs #504

merged 1 commit into from
Oct 13, 2022

Conversation

pierredup
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Tickets N/A
License MIT
  • Fix typo for event (vue:mount instead of vue:before-mount)
  • Add note about history mode when using Vue router

weaverryan
weaverryan reviewed Oct 13, 2022
View reviewed changes
@weaverryan weaverryan added the Status: Waiting Feedback Needs feedback from the author label Oct 13, 2022
weaverryan
weaverryan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@weaverryan weaverryan merged commit 67ac4b0 into symfony:2.x Oct 13, 2022
@pierredup pierredup deleted the patch-1 branch October 13, 2022 14:10
@Kocal
Copy link
Member

Kocal commented Oct 14, 2022

Thanks @pierredup ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
Status: Waiting Feedback Needs feedback from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierredup @Kocal @weaverryan