[DoctrineBundle] Refactoring doctrine:schema:* command descriptions #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the language to be a bit technical, and therefore not totally obvious what these tasks do to the layman. The language here tries to talk more about "generating/executing SQL" so that people know that these are the commands that handle DB table changes.
dunglas
added a commit
to dunglas/symfony-demo
that referenced
this pull request
Mar 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
Since the
doctrine:schema:*commands will be so important day-to-day for a developer, I wanted their descriptions to be a little bit less technical and to stand-out when listing the commands viaphp app/console.If you agree, these changes should be communicated upstream to Doctrine. Really, there's no reason to override the
description, but this gets the change into Symfony more quickly.Thanks!