use !empty() instead of isset() to check framework.validation.cache value

[craue]

No description provided.

[craue]

Just to explain my intention for this...

I wanted to set framework.validation.cache to apc as a default by using a parameters.yml entry, while still being able to override the value and switch off this cache using a parameters_custom.ini entry if APC is not available. But in ini files, you cannot set something to null explicitly, it will just result in an empty string.

I've migrated to parameters_custom.yml as a workaround in the meantime, but it might be useful for others.

[stof]

@craue Use a YAML file instead of an ini file...

[craue]

@stof: I already do (now). Did you actually read my comment above?

[stof]

Actually, the IniFileLoader is flawed. It only allows configuring parameters, and only string parameters (no boolean, no array, no null, no numbers...)

[craue]

Afaik, arrays are possible, but that's OT now. So we will just drop that PR?

[craue]

I guess the IniFileLoader itself won't be fixed/improved, right? It looks as its usage is discouraged altogether. Maybe it should be deprecated then.

[fabpot]

The ini loader is great to configure strings, so we need to keep it. But documentation should probably be updated to warn people about its limitations. Can you close this PR and open a new one on symfony/Symfony-docs instead? Thanks.

[craue]

Is there any documentation for IniFileLoader already? If so, I'm unable to find it.

[stof]

I don't think it is documented

[craue]

Then I'm not sure where to start.

[fabpot]

I've just opened a ticket on the documentation.