Ability to customize payload when sending mail through mailjet+api #45152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @tcheymol has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
tcheymol
reviewed
Feb 2, 2022
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
|
Feels good for me, I can't wait to try this 😁 |
gam6itko
changed the title
nicolas-grekas
changed the title
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
gam6itko
force-pushed
the
mailjet_api_header1
branch
from
92288d0 to
ab974b3
Compare
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Feb 21, 2022
carsonbot
changed the title
fabpot
approved these changes
Feb 25, 2022
|
Thank you @gam6itko. |
fabpot
added a commit
that referenced
this pull request
Feb 25, 2022
… mailjet+api (gam6itko) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- Ability to customize payload when sending mail through mailjet+api | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #44100 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Make able to set custom properties like `TemplateID` via headers. User can easily switch between smtp and api transport with keeping headers payload Commits ------- 9a31686 Ability to customize payload when sending mail through mailjet+api
fabpot
force-pushed
the
mailjet_api_header1
branch
from
765a3ff to
9a31686
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make able to set custom properties like
TemplateIDvia headers.User can easily switch between smtp and api transport with keeping headers payload