Check for Hyper terminal on all operating systems. #27831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot 👍 |
chalasr
approved these changes
Jul 4, 2018
| @@ -225,14 +225,17 @@ private static function hasColorSupport() | |||
| if (!defined('STDOUT')) { | |||
| return false; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
extra spaces here, blank line should be unchanged. See fabbot patch in the CI
| if ('Hyper' === getenv('TERM_PROGRAM')) { | ||
| return true; | ||
| } | ||
|
|
|
@chalasr 👍 |
|
Thank you @azjezz. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 4, 2018
This PR was squashed before being merged into the 2.8 branch (closes #27831). Discussion ---------- Check for Hyper terminal on all operating systems. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT return true if the terminal is Hyper.is on all operating systems not limited to windows. Commits ------- 196e708 Check for Hyper terminal on all operating systems.
This was referenced Jul 23, 2018
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Dec 8, 2023
… (theofidry) This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix color support check on non-Windows platforms | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #45917 | License | MIT Currently checking the color support based on `ANSICON`, `ConEmuANSI=ON` or `TERM=xTerm` is done only for Widows. I could not find any reason as to why and it does not make much sense as it is. Especially if we consider that `TERM=xTerm` is a term check and we do another one (not Widows specific) which is `TERM_PROGRAM=Hyper`. This potentially fixes #45917. This also looks more in line with the intent (based on the title) of #27831 and #27794. Commits ------- 285518d detect colors on not windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return true if the terminal is Hyper.is on all operating systems not limited to windows.