remove defaults from PHPUnit configuration #11344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,13 +3,7 @@ | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.1/phpunit.xsd" | |||
| backupGlobals="false" | |||
There was a problem hiding this comment.
what is the default for backupGlobals ?
There was a problem hiding this comment.
true according to http://phpunit.de/manual/4.1/en/appendixes.configuration.html
|
should this be applied to symfony-standard also? |
|
Sure, will do, @jrobeson. Is the strange formatting meant to be preserved there? |
|
👍 |
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Jul 7, 2014
…oper formatting) (craue) This PR was merged into the 2.3 branch. Discussion ---------- update PHPUnit configuration (add XSD, remove defaults, proper formatting) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- See symfony/symfony#11344. Commits ------- 324692e updated PHPUnit configuration (added XSD, removed defaults, proper formatting)
|
Thank you @craue. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2014
This PR was merged into the 2.3 branch. Discussion ---------- remove defaults from PHPUnit configuration | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Follow-up to #11329. Commits ------- afc4930 removed defaults from PHPUnit configuration
|
Can anyone comment on why the Symfony project sets |
|
git blame? |
|
@bkosborne I guess this is because our testsuite does not need to backup globals. We avoid global state almost everywhere in Symfony (I would find it very good if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11329.