This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Removing the symfony-tests-dir composer extra config - it's not used #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally proposed for sensiolabs/SensioGeneratorBundle#416, but that is being solved in a different way.
|
Why not use this configuration setting in #494? |
|
@fabpot afaik, there is no way to read composer.json extra values at runtime (other than parsing the file manually). Plus, are we sure we want the extra |
|
Is it worth removing it ? I can think of some use cases in third party library. |
|
Let's keep it, it does not hurt. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally proposed for sensiolabs/SensioGeneratorBundle#416 (in #862), but I'm proposing to solve that in a simpler way: sensiolabs/SensioGeneratorBundle#494
Thanks!