This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Improve text on the welcome page #931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@regularjack thanks for your pull request. Before merging it, I'd like to ask the review from @weaverryan, our native English speaker. Thanks! |
| @@ -11,7 +11,7 @@ | |||
| <p> | |||
| <svg id="icon-status" width="1792" height="1792" viewBox="0 0 1792 1792" xmlns="http://www.w3.org/2000/svg"><path d="M1671 566q0 40-28 68l-724 724-136 136q-28 28-68 28t-68-28l-136-136-362-362q-28-28-28-68t28-68l136-136q28-28 68-28t68 28l294 295 656-657q28-28 68-28t68 28l136 136q28 28 28 68z" fill="#759E1A"/></svg> | |||
|
|
|||
| Your application is ready to start working on it at: | |||
| You're ready to start working on your application at: | |||
There was a problem hiding this comment.
I would split this in 2 sentences, something along the lines of:
"Your application is ready now. Start working on it at:"
|
Apart @fabpot's comment, I'm 👍 on this |
|
I also agree with @fabpot's comment. Just fixed it. |
|
👍 |
|
👍 sounds better to me too |
|
Thank you @regularjack. |
fabpot
added a commit
that referenced
this pull request
Jan 19, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #931). Discussion ---------- Improve text on the welcome page The text on the welcome page was not a proper English sentence. I took the chance to also improve the "read the docs" sentence to not mention Symfony twice. Commits ------- becd595 Improve text on the welcome page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text on the welcome page was not a proper English sentence. I took the chance to also improve the "read the docs" sentence to not mention Symfony twice.