This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Referencing scripts in composer.json to avoid duplication #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It forces users to update their composer installation, and even if composer itself sends warnings, I don't know if it's a best practice. |
|
Given that it's included in a tagged release and that release is even more than a month old I am 👍 on this. |
|
Please note that the Composer update warnings are no shown after 60 days instead of 30, maybe it's better to wait another month? |
|
Oh did they exceed that value? |
|
We already use |
|
I think we can merge this now 👍 |
|
That's very different. If config.platform is not taken into account, that's no big deal. Here, if script references are not supported, hooks do not work anymore. |
|
Thank you @1ed. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2016
…(1ed) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #918). Discussion ---------- Referencing scripts in composer.json to avoid duplication It's a new feature of composer ([referencing-scripts](https://getcomposer.org/doc/articles/scripts.md#referencing-scripts)) available as of [1.0.0-alpha11](https://github.com/composer/composer/releases/tag/1.0.0-alpha11). Commits ------- 4935d2c Referencing scripts to avoid duplication
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a new feature of composer (referencing-scripts) available as of 1.0.0-alpha11.