This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Use Kernel::getEnvironment() to keep consistency #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 , I think this should also be merged in 2.7 and 2.8 |
|
@Pierstoval the changes of #850 are for the master branch only |
|
Fine, I didn't look 👍 |
|
Thank you @dosten. |
Tobion
added a commit
that referenced
this pull request
Nov 29, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- Use Kernel::getEnvironment() to keep consistency Hi there! The PR #850 introduced the use of the variable `$this->environment` to get the environment, but we already use the method `Kernel::getEnvironment()`, this PR fixes this to keep consistency. Please review this before the Symfony 3.0 release. Commits ------- d7320f7 Use Kernel::getEnvironment() to keep consistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
The PR #850 introduced the use of the variable
$this->environmentto get the environment, but we already use the methodKernel::getEnvironment(), this PR fixes this to keep consistency.Please review this before the Symfony 3.0 release.