This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Update phpunit configuration #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,7 @@ | |||
| <testsuite name="Project Test Suite"> | |||
| <directory>../src/*/*Bundle/Tests</directory> | |||
| <directory>../src/*/Bundle/*Bundle/Tests</directory> | |||
| <directory>../src/*Bundle/Tests</directory> | |||
There was a problem hiding this comment.
We can move this up so that we have the same order here as in the filter below.
There was a problem hiding this comment.
👍 looks prettier 😉
There was a problem hiding this comment.
Ah sorry, I did not see that we had it in the other order in the 2.7 branch.
|
👍 |
1 similar comment
|
👍 |
|
Please change the order of the directories to be the same as in 2.7 to ease merging: https://github.com/symfony/symfony-standard/blob/2.7/app/phpunit.xml.dist |
|
and please update the code coverage whitelist too (take it from the 2.7 branch too) |
|
@stof the code coverage whitelist is already up to date I guess, isn't? |
Fix a problem since the bundle without vendor name directly inside the src directory are not going to be tested.
|
Is there still any code changes needed or everything is fine? |
|
Thank you @amansilla. |
Tobion
added a commit
that referenced
this pull request
Oct 13, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Update phpunit configuration | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3 | Fixed tickets | #865 Fix a problem since the bundle without vendor name directly inside the src directory are not going to be tested. Commits ------- 4bbb548 Update phpunit configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem since the bundle without vendor name directly
inside the src directory are not going to be tested.