[3.0] move tests out of src folder

[Pierstoval]

Fixes #855

[stof]

tests is enough actually

[stof]

no need for a .gitkeep in tests IMO

[Pierstoval]

Fixed in b83f70e, thanks @stof

[Pierstoval]

We may also have to change the sensiolabs/SensioGeneratorBundle generate:bundle command in order to add the tests directly in this new directory, or the default generated tests would not be automatically added to the test suite

[gnugat]

Looks good to me, the choice of Tests root namespace allow less constraints than AppBundle\Test.
👍

[fabpot]

I would have put that into AppBundle instead: Tests\AppBundle\Controller

[Pierstoval]

Done in b71ca58, thanks @fabpot

[Tobion]

The autoload-dev does not match the test namespace.

[Pierstoval]

@Tobion Fixed it in 2856777, if it's what you meant :)

[xabbuh]

Why not use AppBundle\\Tests\\ here so that we can keep using the AppBundle\Tests namespace prefix in the test classes?

[stof]

Well, if you define multiple bundles, this would make it harder to follow the structure (you would have to change the structure of the testsuite)

[Pierstoval]

I don't know... Forcing the namespace to Tests instead of an empty one sounds better to me because there should not be any other thing than tests.

If we wanted to use AppBundle\Tests it would need the PSR-4 to be { "" : "test/" } and we could put almost anything in it.

Plus, the bundle structure is merely optional, even if @fabpot advised adding it.
At first I prepared the structure as tests/Controller/DefaultControllerTest.php because here we have the whole application tests, and the bundle structure seemed less important to me than the tests we may add in it.

[Tobion]

👍 good to merge IMO

The remaining thing already has an issue on sensiolabs/SensioGeneratorBundle#416

[weaverryan]

I share @stof's concern: I recommend the single bundle approach, but I also think adding multiple bundles shouldn't require reworking your structure.

[fabpot]

@weaverryan What would you have to change in a multiple-bundle approach?

[weaverryan]

@fabpot nevermind - I don't know what I was looking at. Tests\AppBundle clearly is laid out perfectly for multi-bundles: 👍

[fabpot]

Thank you @Pierstoval.