Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Use a proper version constraint #852

Merged
merged 1 commit into from Oct 28, 2015
Merged

Use a proper version constraint #852

merged 1 commit into from Oct 28, 2015

Conversation

GrahamCampbell
Copy link
Contributor

Any reason why this wasn't used already? I noticed this when looking at #850.

@gnugat
Copy link

gnugat commented Sep 16, 2015

You could push it a little bit further: ^2.8.0@dev

@mickaelandrieu
Copy link

humm, should be also done for Symfony3

@GrahamCampbell
Copy link
Contributor Author

You could push it a little bit further: ^2.8.0@dev

👎 because all other branches are like 2.7.*.

@GrahamCampbell
Copy link
Contributor Author

^2.8.0@dev - that's wrong anyway, because it would include 2.9+ too. Yes, I know 2.8 is the last 2.x minor release, but that version constraint would be wrong, semantically.

@GrahamCampbell
Copy link
Contributor Author

Ping @fabpot. :)

@Tobion
Copy link
Contributor

Tobion commented Oct 28, 2015

Thank you @GrahamCampbell.

@Tobion Tobion merged commit 8d04960 into symfony:2.8 Oct 28, 2015
Tobion added a commit that referenced this pull request Oct 28, 2015
@Tobion
minor #852 Use a proper version constraint (GrahamCampbell)
bfdf629 
This PR was merged into the 2.8 branch.

Discussion
----------

Use a proper version constraint

Any reason why this wasn't used already? I noticed this when looking at #850.

Commits
-------

8d04960 Use a proper version constraint
@GrahamCampbell GrahamCampbell deleted the patch-1 branch October 28, 2015 17:32
@GrahamCampbell
Copy link
Contributor Author

:)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GrahamCampbell @gnugat @mickaelandrieu @Tobion