Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

update Doctrine Configuration in config.yml #839

Closed
wants to merge 1 commit into from
Closed

update Doctrine Configuration in config.yml #839

wants to merge 1 commit into from

Conversation

ykseiljon
Copy link

allow to use other database driver from parameters.yml

allow use other database driver from parameters.yml
@ogizanagi
Copy link
Contributor

The database_driver parameter does not exist anymore in app/config/parameters.yml.dist

Additionally, have a look at #722 (comment) and #776

@ykseiljon
Copy link
Author

I updated app/config/parameters.yml, then i need to change config.yml to connect to other database driver and worked well.
If I use assistant to configure database connection it show that parameter (database_driver on app/config/parameters.yml).

@ogizanagi
Copy link
Contributor

The issue is that you updated the app configuration to use the database_driver, but you didn't edit the parameters.yml.dist file from this repository within your PR.
parameters.yml.dist file which is used by the Composer Incenteev parameter handler to ask the user the parameters values after a composer install.

Doing a fresh install of symfony standard edition will then fail, because of that missing parameter from the .dist file. The database_driver parameter will never be created in parameters.yml.

Also, the database_driver parameter used to exist, but has been removed. (See above referenced PRs for more informations about that)

@ykseiljon
Copy link
Author

thanks, after check it i understand reason, it work good if i write driver of appropriate database in config.yml

@Pierstoval
Copy link
Contributor

IIRC, the database_driver was removed from parameters.yml because it's mostly a "project-related" parameter, not a "platform-related".

Everything in the parameters.yml should depend only on the platform in which you deploy/dev/test your app, and the rest should stay in config.yml, this is why this parameter was removed from the dist file.

For this reason, I'm totally 👎 for this PR.

@xabbuh
Copy link
Member

xabbuh commented Jul 23, 2015

@Pierstoval is right. That's the reason why the parameter was removed in #776 (see #776 (comment)). Therefore I'm going to close here.

@xabbuh xabbuh closed this Jul 23, 2015
@ykseiljon
Copy link
Author

I get it. But then I think is necessary to update configuration assistant, because it still write database_driver in parameter.yml. Thanks for answer.

@xabbuh
Copy link
Member

xabbuh commented Jul 24, 2015

Did you experience that behaviour with a freshly installed Symfony application?

@Pierstoval
Copy link
Contributor

@xabbuh I've tested on a freshly installed 2.7 version and actually, the SensioDistribution:Configurator controller adds the database_driver to parameters.yml.

I didn't use this component for months, but actually, it also generates a completely inline parameters.yml file. I'm on MacOSX10.10.

@ykseiljon
Copy link
Author

@xabbuh, @Pierstoval is right. And I appreciate the explanations of the change reasons and understood. It's sense to me too.

@Pierstoval
Copy link
Contributor

The issue is then related to SensioDistributionBundle, I think we can close it here

@xabbuh
Copy link
Member

xabbuh commented Jul 25, 2015

see sensiolabs/SensioDistributionBundle#219

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants