Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

[2.8] update composer dependencies #805

Merged
merged 1 commit into from
May 12, 2015

Conversation

vincentaubert
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@vincentaubert
Copy link
Contributor Author

link to issue #806

@GrahamCampbell
Copy link
Contributor

There's more than one fix in here. Shouldn't they be separated?

@vincentaubert
Copy link
Contributor Author

The Symfony requirements file has been automatically updated by composer when I ran the composer update command. So I propose to add it.

@GrahamCampbell
Copy link
Contributor

Ok. :)

@Tobion
Copy link
Contributor

Tobion commented May 11, 2015

This needs to be redone as I merged 2.7 upwards. So the composer.json changed again.

@vincentaubert
Copy link
Contributor Author

done

@Tobion
Copy link
Contributor

Tobion commented May 12, 2015

Please squash the commits into one.

@vincentaubert vincentaubert force-pushed the 2.8_update_composer branch from 7560c62 to 3865af3 Compare May 12, 2015 19:00
@vincentaubert
Copy link
Contributor Author

done

Tobion added a commit that referenced this pull request May 12, 2015
@Tobion Tobion merged commit acdf151 into symfony:2.8 May 12, 2015
@vincentaubert vincentaubert deleted the 2.8_update_composer branch May 13, 2015 05:25
@lyrixx
Copy link
Member

lyrixx commented May 13, 2015

@Tobion Why don't you merge PR with GH ? it eases work of contributor, and also the work of people who write blog post about new features.

@fabpot
Copy link
Member

fabpot commented May 13, 2015

I missed that but indeed, all merge must be done with GH.

@Tobion
Copy link
Contributor

Tobion commented May 13, 2015

I didn't know I can use GH for PRs on symfony-standard. Will do so from now on.
Does GH support different naming of the "origin" remote by now? Otherwise I have to rename my remotes there as well :(

@stof
Copy link
Member

stof commented May 13, 2015

@Tobion you can use it for any repo.
And no, it only support origin (I was the only one interested in this feature at this time, and I changed my naming convention for remotes when changing computer, so I never completed the work on this). See the discussion on the GH repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants