Update ORM requirements to allow DBAL 2.5 again #800
Conversation
| @@ -9,8 +9,7 @@ | |||
| "require": { | |||
| "php": ">=5.3.3", | |||
| "symfony/symfony": "2.3.*", | |||
| "doctrine/orm": "~2.2,>=2.2.3,<2.5", | |||
| "doctrine/dbal": "<2.5", | |||
| "doctrine/orm": "~2.2.3||~2.3.0||~2.4.8||~2.5", | |||
There was a problem hiding this comment.
is the doc wrong https://getcomposer.org/doc/01-basic-usage.md#package-versions ?
There was a problem hiding this comment.
both are valid as of alpha10. A single | works on older versions
There was a problem hiding this comment.
And I suggest dropping 2.2 and 2.3 here. They are EOLed versions of Doctrine
There was a problem hiding this comment.
changed. I also used the caret operator now. I guess it's time. And it's the responsibility of the people manually updating their dependencies anyway.
| @@ -9,15 +9,14 @@ | |||
| "require": { | |||
| "php": ">=5.3.3", | |||
| "symfony/symfony": "2.3.*", | |||
| "doctrine/orm": "~2.2,>=2.2.3,<2.5", | |||
| "doctrine/dbal": "<2.5", | |||
| "doctrine/orm": "^2.4.8", | |||
| "doctrine/doctrine-bundle": "~1.2", | |||
| "twig/extensions": "1.0.*", | |||
There was a problem hiding this comment.
this one should be changed to ~1.0 to allow to use uptodate versions (the latest stable is 1.2.0)
|
@Tobion ORM 2.4.7 works with DBAL 2.5.x |
|
@Ocramius what do you mean with "works"? Does it not cause #748? How did you fix it for these version? |
|
It's not fixed in ORM 2.5 either. Marco Pivetta On 17 April 2015 at 16:01, Tobias Schultze notifications@github.com wrote:
|
|
Then why does the error not appear anymore in ORM 2.5 if it's not fixed? |
|
Luck? I see no explicit fix happening. That said, ORM 2.5 is DBAL 2.5 compatible, just platform auto-detection in DBAL is broken. |
|
/cc @deeky666 |
|
@Ocramius the auto-detection implementation in DBAL is fine: it is delayed until you retrieve the Platform from the connection (at which point the result of the detection is needed). As I explained several times already (including in http://www.doctrine-project.org/jira/browse/DBAL-1057 which tracks this officially), the issue is that the ORM was retrieving the platform in many places in the constructor instead of doing it only when it actually needs it. This means that just instantiating the ORM was asking for the platform at the right version. |
|
Can we merge this one? |
|
Not yet. Doctrine needs to tag a new release which seems very hard to do. See doctrine/DoctrineBundle#351 (comment) |
|
s/hard/time-consuming-during-my-evening-that-is-already-fully-booked-for-these-weeks Marco Pivetta On 5 May 2015 at 19:59, Tobias Schultze notifications@github.com wrote:
|
As per Symfony standard we need to wait until https://github.com/symfony/symfony-standard/issues/748 and symfony/symfony-standard#800 are closed
|
ping @beberlei can you tag doctrine orm 2.4.8 maybe? |
|
and also doctrine orm 2.5.1 |
|
Doctrine 2.4.8 has been released. So this can be merged. |
|
Thank you @Tobion. |
This PR was merged into the 2.3 branch. Discussion ---------- Update ORM requirements to allow DBAL 2.5 again @Ocramius could doctrine release ORM 2.4.8 so doctrine/orm@e05930e is tagged? I think orm <2.4.8 is incompatible with DBAL 2.5. Commits ------- f92af02 allow semantic twig extension versions 49b8620 orm 2.2 and 2.3 are end of life 2f523d8 Update ORM requirements to allow DBAL 2.5 again
|
Don't forget to update the lock file. It's now out of sync and references DBAL 2.4.4 which is incompatible with the current requirements from composer.json. |
|
The lock file gets updated before each release. |
|
See a522d9d for example. |
|
It's not out of sync. |
|
Just the newer branches not updated yet since there's not been a release there since. |
|
@GrahamCampbell: I see, thanks for clarifying. |
@Ocramius could doctrine release ORM 2.4.8 so doctrine/orm@e05930e is tagged? I think orm <2.4.8 is incompatible with DBAL 2.5.