This repository was archived by the owner on Nov 27, 2020. It is now read-only.
[WIP] Adding a quick note explaining paramters.yml.dist a little #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding a description to one key that is a little less obvious
|
I think you meant
|
| @@ -1,3 +1,4 @@ | |||
| # This file is a "template" or what your parameters.yml file should look like | |||
There was a problem hiding this comment.
Maybe I'm wrong, but I think that there is a typo:
# This file is a "template" or what your ...
# This file is a "template" of what your ...
There was a problem hiding this comment.
In my opinion "should" is better because this is a best practice agreed by almost all developers.
| @@ -12,4 +13,6 @@ parameters: | |||
| mailer_password: ~ | |||
|
|
|||
| locale: en | |||
|
|
|||
| # A secret key that's used for certain things, like generating CSRF tokens | |||
There was a problem hiding this comment.
The CSRF system does not use it anymore in 2.4+
|
@weaverryan Is it still WIP? |
|
@fabpot Sorry - we can merge it, and I can add an additional note later when the docs are ready. |
|
Thank you @weaverryan. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is really simple, but a WIP because I also want to add an additional link at the top to symfony/symfony-docs#4174 after it's created.
Thanks!