Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Allow Doctrine 2.4 to be installed #612

Merged
merged 1 commit into from
Mar 14, 2014
Merged

Allow Doctrine 2.4 to be installed #612

merged 1 commit into from
Mar 14, 2014

Conversation

jdespatis
Copy link
Contributor

The commit 0cafa50#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780, lets Doctrine 2.4 installable

But it has been performed only on master, 2.4

Any reason why it shouldn't also be backported to last stable version of symfony-standard (2.3) ?

@@ -9,7 +9,7 @@
"require": {
"php": ">=5.3.3",
"symfony/symfony": "2.3.*",
"doctrine/orm": ">=2.2.3,<2.4-dev",
"doctrine/orm": ">=2.2.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is too general as u can compare with my commit on master

@Tobion
Copy link
Contributor

Tobion commented Dec 1, 2013

Btw, git allows cherry-picking commits.

@jdespatis
Copy link
Contributor Author

yes @Tobion , but I wanted to test squashing ;)

The fact is I've read the git doc one week ago

fabpot added a commit that referenced this pull request Mar 14, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Allow Doctrine 2.4 to be installed

The commit 0cafa50#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780, lets Doctrine 2.4 installable

But it has been performed only on `master`, `2.4`

Any reason why it shouldn't also be backported to last stable version of `symfony-standard` (`2.3`) ?

Commits
-------

42937c1 Allow Doctrine 2.4 to be installed
@fabpot fabpot merged commit 42937c1 into symfony:2.3 Mar 14, 2014
@jdespatis jdespatis deleted the doctrine-2.4 branch March 14, 2014 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants