This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Backport issue 426 / PR 429 to master #610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open for the 2.2 branch instead? I will then merge it into 2.3 and master. Thanks. |
|
ok => #611 I can then close this one I guess |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yaml config files into
app/configare not validThis issue has already been reported one year ago with issue #426, and has been fixed thanks to PR #429
However, it seems that this PR has been merged into branch 2.1, and not backported into master
Therefore this bug still exists in master, 2.2, 2.3 and 2.4
Here is a PR to merge into master (and it would need a backport into 2.3 and 2.4 at least ?, and maybe a new tag for each)
The fact is I need to parse those yaml files with a Node.js module, and it just throws an error, because of this invalidity