made browser logs commented by defaults (refs symfony/symfony#8413) #569
Conversation
|
FirePHP should not break it as it uses a separate header for each log entry, so the header does not become too big. ChromePHP indeed makes the heade size grow as it uses a single header. |
| type: chromephp | ||
| level: info | ||
| # uncomment to get logging in your browser | ||
| # you may have to allow bigger header sizes in your Web server configuration |
There was a problem hiding this comment.
i think nginx should be mentioned specifically in the comment. What other web servers require this configuration?
|
I think both handlers should not be enabled by default because the feature should be opt-in and not opt-out. |
|
See the referenced issue. Only ChromePHP breaks without tuning the configuration of nginx. But I'm fine disabling both. |
|
+1 I got this issue so much time... |
This PR was merged into the master branch. Discussion ---------- made browser logs commented by defaults (refs symfony/symfony#8413) FirePHP and ChromePHP are now disabled by default as they can make the application broke if the web server is not configured with large header sizes. see symfony/symfony#8413 Commits ------- 262af2d made browser logs commented by defaults (refs #8413)
|
@fabpot you can remove the monolog-tweaks branch from the repo |
|
Should it also be backported to 2.3 (as it's the LTS version)? |
FirePHP and ChromePHP are now disabled by default as they can make the application broke if the web server is not configured with large header sizes.
see symfony/symfony#8413