This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Register WebServerBundle #1042
Closed
Register WebServerBundle #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jan 6, 2017
| @@ -13,6 +13,7 @@ public function registerBundles() | |||
| new Symfony\Bundle\TwigBundle\TwigBundle(), | |||
| new Symfony\Bundle\MonologBundle\MonologBundle(), | |||
| new Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle(), | |||
| new Symfony\Bundle\WebServerBundle\WebServerBundle(), | |||
There was a problem hiding this comment.
Should probably be registered only for the dev environment.
chalasr
force-pushed
the
wire-webserverbundle
branch
2 times, most recently
from
462e339 to
e335928
Compare
fabpot
reviewed
Jan 6, 2017
| @@ -21,6 +21,7 @@ public function registerBundles() | |||
| if (in_array($this->getEnvironment(), ['dev', 'test'], true)) { | |||
| $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle(); | |||
| $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle(); | |||
| $bundles[] = new Symfony\Bundle\WebServerBundle\WebServerBundle(); | |||
There was a problem hiding this comment.
I would really add it just for the dev env, it does not make sense to register it for the test one, right?
There was a problem hiding this comment.
Good point, fixed. Wouldn't the same be relevant for SensioGeneratorBundle?
There was a problem hiding this comment.
Shall we make the change here?
stof
reviewed
Jan 6, 2017
| @@ -4,7 +4,8 @@ | |||
| "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", | |||
| "This file is @generated automatically" | |||
| ], | |||
| "content-hash": "e8806838d7235c3d2ab386293836949f", | |||
| "hash": "3749ec07f0cd5aa8a58d5252a2c19ca4", | |||
| "content-hash": "dbdc24fc713f6a6da88dcdff23201f1b", | |||
There was a problem hiding this comment.
please update your composer version to use composer 1.3, instead of reverting the lock file to things created by an older version (different date format and the old hash), and then regenerate the lock with composer update --lock
chalasr
force-pushed
the
wire-webserverbundle
branch
from
e335928 to
f143530
Compare
|
Thank you @chalasr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates vendors which was locked to 3.2.1 and registers the WebServerBundle.
Closes #1041