This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Allow to install Symfony when the directory exists but it's empty #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Checks whether the given directory is empty or not. | ||
| * | ||
| * @param string $dir the path of the directory to check | ||
| * @return boolean True if the directory is empty. False otherwise. |
|
👍 now :) |
| * Checks whether the given directory is empty or not. | ||
| * | ||
| * @param string $dir the path of the directory to check | ||
| * @return bool True if the directory is empty. False otherwise. |
There was a problem hiding this comment.
True if the directory is empty. False otherwise. could be removed. The name of the method already makes the meaning of the boolean clear
There was a problem hiding this comment.
You are right. Removed that redundant explanation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #98