Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

suggest to use symfony.phar on Windows #67

Merged
merged 1 commit into from
Dec 4, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 3, 2014

The command that is suggested since #59 when the download of a non-existent Symfony version fails, is not sufficient on Windows. We need to suggest php symfony.phar ... instead.

@javiereguiluz
Copy link
Member

@xabbuh thanks for taking into account these details. However, as we usually use symfony for Mac and Linux instead of php symfony, what do you think about simplifying your proposal as follows?

'php symfony%s %s %s latest',
...
defined('PHP_WINDOWS_VERSION_BUILD') ? '.phar' : '',
'%s %s %s latest',
...
defined('PHP_WINDOWS_VERSION_BUILD') ? 'php symfony.phar' : 'symfony',

@xabbuh xabbuh force-pushed the improve-installer-command branch from 55e5f8d to 6a7324d Compare December 3, 2014 22:50
@xabbuh
Copy link
Member Author

xabbuh commented Dec 3, 2014

@javiereguiluz Of course, you're right.

@fabpot
Copy link
Member

fabpot commented Dec 4, 2014

Thank you @xabbuh.

@fabpot fabpot merged commit 6a7324d into symfony:master Dec 4, 2014
fabpot added a commit that referenced this pull request Dec 4, 2014
This PR was merged into the 1.0-dev branch.

Discussion
----------

suggest to use symfony.phar on Windows

The command that is suggested since #59 when the download of a non-existent Symfony version fails, is not sufficient on Windows. We need to suggest `php symfony.phar ...` instead.

Commits
-------

6a7324d suggest to use symfony.phar on Windows
@xabbuh xabbuh deleted the improve-installer-command branch December 4, 2014 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants