Create the .gitignore file as part of the installation

[unfunco]

The .gitignore file is not included as part of the installation.

I'm not sure whether this is the best method to accomplish this, since it potentially requires maintenance of the $ignored array, I'll gladly take suggestions...

[javiereguiluz]

@unfunco thanks for reporting this error. We definitely need to maintain the .gitignore file. As you pointed, creating the file is straightforward, but it requires maintenance. So I'm all in for trying to move this requirement upwards to Distill library.

@raulfraile do you think it would make sense to allow dot files in your Distill library? Thanks.

[raulfraile]

@unfunco SKIP_DOTS is only used in Distill to check if the decompressed data contains only a single directory, it is not used to move or extract the files.

@javiereguiluz They are allowed, I am not sure if the error is in the Distill library, I have to do some tests. BTW -1 to this PR as it requires maintenance and is error prone, we just need to make sure that all files included in the compressed file, even dot files, are decompressed.

[raulfraile]

Looks like the zip file does not contain the .gitignore file:

unzip -l ~/Downloads/Symfony_Standard_Vendors_2.6.0.zip|grep -c gitignore
0

It contains other dotfiles though, like the .htaccess file:

unzip -l ~/Downloads/Symfony_Standard_Vendors_2.6.0.zip|grep htaccess    
      143  11-24-14 08:30   Symfony/app/.htaccess
      143  11-24-14 08:30   Symfony/src/.htaccess
     2787  11-24-14 08:30   Symfony/web/.htaccess

[stof]

SKIP_DOTS only skips . and .., not .gitignore

[stof]

and I agree that it would be better to fix the archive creation

[javiereguiluz]

@raulfraile thanks for investigating this issue!

@stof you are right. We're going to change the way the files are generated on symfony.com to avoid removing the .gitignore file.

By the way, I'm going to leave this issue opened as a reminder of this pending task.

[raulfraile]

@javiereguiluz as you are going to tweak the script to generate the compressed files, maybe it's a good time to create tar.bz2 and tar.xz files, as their compression ratio is much better :)

tar -jcvf symfony.tar.bz2 [files]
tar -Jcvf symfony.tar.xz [files]

Even though they are not included in the installer yet, it could be useful to perform some tests and compare that all extracted directories from all formats have the same files. Distill already supports those formats.

[javiereguiluz]

Closing it because the code of this PR was used in the more generic #103 PR which has just been merged. @unfunco thanks again for your help.