This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Update Guzzle to version 5 to avoid PHP 7 issues #182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $size = $event->downloadSize; | ||
| $downloaded = $event->downloaded; | ||
|
|
||
| if ($size < 1 * 1024 * 1024) { |
There was a problem hiding this comment.
Is the first 1 really necessary?
There was a problem hiding this comment.
I guess not 😄 It's just a personal preference to read it more clearly as "1 megabyte". Should I change it?
There was a problem hiding this comment.
A small comment above the instruction might be more verbose about this :)
|
if it works fine, 👍 |
javiereguiluz
force-pushed
the
update_guzzle
branch
from
755e047 to
1525870
Compare
|
Looks like Box cannot be installed on HHVM. what could be done is installing and running Box with php 5.6 all the time (you can access it as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guzzlehttp/progress-subscriberhas been removed because it's declared asDEPRECATEDand it requires Guzzle 4.