Skip to content

Update framework.rst #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Update framework.rst #9965

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47e3761
Update framework.rst
apodgorbunschih Jun 26, 2018
29308c9
Update framework.rst
apodgorbunschih Jun 26, 2018
052b07b
add missing details, and more explicit description for default_path o…
Jul 13, 2018
f5fe2ae
Merge branch '3.4' into patch-1
Jul 13, 2018
ff52a05
fix travis markup error
Jul 13, 2018
7529ad9
fix travis markup error
Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions reference/configuration/framework.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ Configuration
* `fallbacks`_
* `logging`_
* :ref:`paths <reference-translator-paths>`
* :ref:`default_path <reference-translator-default_path>`
* `property_access`_
* `magic_call`_
* `throw_exception_on_invalid_index`_
Expand Down Expand Up @@ -1560,6 +1561,16 @@ paths
This option allows to define an array of paths where the component will look
for translation files.

.. _reference-translator-default_path:

default_path
.....
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format we use for the docs is more strict that Markdown, so for example, the line below the heading must have the exact same length. Please, add the missing dots like this:

default_path
............


**type**: ``string`` **default**: ``[]``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value looks wrong to me (this should be %kernel.project_dir%/translations)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are right


This option allows to define a path where the component will write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this description. Should we change it for this other description?

This option allows to define the path where the application translations files
are stored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's two default things: it is where the command generates translation files and where domains take precedence on other registrations.

the translation files.

property_access
~~~~~~~~~~~~~~~

Expand Down