Skip to content

Fixed security expression testing user #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed security expression testing user #9929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions security.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,15 +964,15 @@ You can also use expressions inside your templates:
.. code-block:: html+jinja

{% if is_granted(expression(
'"ROLE_ADMIN" in roles or (user and user.isSuperAdmin())'
'"ROLE_ADMIN" in roles or (not is_anonymous() and user.isSuperAdmin())'
)) %}
<a href="...">Delete</a>
{% endif %}

.. code-block:: html+php

<?php if ($view['security']->isGranted(new Expression(
'"ROLE_ADMIN" in roles or (user and user.isSuperAdmin())'
'"ROLE_ADMIN" in roles or (not is_anonymous() and user.isSuperAdmin())'
))): ?>
<a href="...">Delete</a>
<?php endif; ?>
Expand Down
2 changes: 1 addition & 1 deletion security/expressions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ accepts an :class:`Symfony\\Component\\ExpressionLanguage\\Expression` object::
public function indexAction()
{
$this->denyAccessUnlessGranted(new Expression(
'"ROLE_ADMIN" in roles or (user and user.isSuperAdmin())'
'"ROLE_ADMIN" in roles or (not is_anonymous() and user.isSuperAdmin())'
));

// ...
Expand Down