Transition from mt_rand to random_int #9903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2018 09:49
See: http://php.net/manual/en/function.mt-rand.php ``` Caution This function does not generate cryptographically secure values, and should not be used for cryptographic purposes. If you need a cryptographically secure value, consider using random_int(), random_bytes(), or openssl_random_pseudo_bytes() instead. ``` Of course, this example is not doing anything "cryptographically secure". However, it does seem to make sense to promote using the more secure way of generating random numbers, to nudge people in the right direction if they do start building cryptographically sensitive stuff.
|
@sbol-coolblue this is a really nice proposal. I like it a lot! In case we're worried because So I propose to merge this in 2.8 branch. There's no need for you to rebase or change anything. We can change it when merging. Thanks! |
|
Merged! (in 2.8 branch). Thank you Sander ... and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jun 9, 2018
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #9903). Discussion ---------- Transition from mt_rand to random_int Considering that mt_rand has a warning notice surrounding it, having the examples use random_int nudges people in the direction of the more secure way of generating random ints, building better habits. Commits ------- 2e68ee7 Transition from mt_rand to random_int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering that mt_rand has a warning notice surrounding it, having the examples use random_int nudges people in the direction of the more secure way of generating random ints, building better habits.