-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Mentioned Debian explicitly #9899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Question: The next sentence ("That's why...") doesn't make sense to me! If Debian thinks it's better to do it with its own cronjob, **why** is Symfony overwriting it?? => Suggestion: Symfony overwrites this value to ``1``, because ...
I'm not sure about this change. The reason is that we're always hesitant to include too specific info like mentioning Debian as one of the OS that do this. The problem of doing that is that it forces us to check every current and future version of Debian to see if that statement is still true. But let's wait to read more opinions about this. Thanks! |
I committed this PR primarily cause I had this message several times in my nginx error log, and it was hard to find out what the reason is:
So what I'm really suggesting would be two things:
The "Debian" question is less important. And I certainly see your point. What about something like "some versions of Debian"? Making an exception for Debian is justified, I would say, since it's (a) (probably) the most widely used OS on webservers, and (b) many other Linux distros depend on it. But, again, the other two points are far more important! |
I think we need help from someone who knows this well (@Tobion, @stof, @nicolas-grekas, ...) so they can explain to us why does Symfony do this. Thanks! |
@nicolas-grekas thanks for reviewing! We'd also need your help to understand this:
Symfony knows better than Debian and overrides this setting silently? Thanks! |
@javiereguiluz as soon as you configure a session save path in the Symfony config (rather than using the one from php.ini), relying on the Debian cron job does not work at all (as the cron job will clean a different location than the one used when saving). |
Thanks Thomas. |
This PR was merged into the 2.8 branch. Discussion ---------- Mentioned Debian explicitly Question: The next sentence ("That's why...") doesn't make sense to me! If Debian thinks it's better to do it with its own cronjob, **why** is Symfony overwriting it?? => Suggestion: Symfony overwrites this value to ``1``, because ... Commits ------- 67d2f87 Mentioned Debian explicitly
@stof Wouldn't it be better to include a comment inside the yaml file (something like "If you change this, make sure to...")? I mean: The current setting produces error log entries for many people. That's not good ;-) |
Question: The next sentence ("That's why...") doesn't make sense to me! If Debian thinks it's better to do it with its own cronjob, why is Symfony overwriting it?? => Suggestion: Symfony overwrites this value to
1
, because ...