Change code file location #9883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know if it's an error, but common practices is to define services in `app/config/services.yml`
javiereguiluz
added
Status: Reviewed
bug
Console
and removed
Status: Needs Review
labels
|
Thank you! We fixed other wrong file paths for XML and PHP too. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 6, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Change code file location I don't know if it's a "mistake", but common practices is to define services in `app/config/services.yml` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 9960f0c Fixed some wrong file paths 8e2ff4a Change code file location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's a "mistake", but common practices is to define services in
app/config/services.yml