add missing XML and PHP code examples #9871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
best reviewed with whitespaces ignored |
xabbuh
commented
Jun 2, 2018
| <parameter key="env(AUTH_FILE)">../config/auth.json</parameter> | ||
| </parameters> | ||
|
|
||
| <google auth="%env(file:AUTH_FILE)%" /> |
There was a problem hiding this comment.
I don't know which bundle this example was based on. Should we find a "better" example?
There was a problem hiding this comment.
I don't know which example was based on ... but Composer optionally defines an auth.json file: https://getcomposer.org/doc/articles/http-basic-authentication.md
There was a problem hiding this comment.
I think @mcfedr who created the initial examples should be able to help us here. :)
There was a problem hiding this comment.
Its not a from a specific bundle, I couldn't find any obvious examples where it was useful to inject a file, this is from one of my projects where I inject a google apis private key.
|
Thank you Christian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9831