Skip to content

Update tags declaration in yaml format #9858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update tags declaration in yaml format #9858

wants to merge 1 commit into from

Conversation

ScullWM
Copy link
Contributor

@ScullWM ScullWM commented May 30, 2018

No description provided.

@javiereguiluz
Copy link
Member

It's not strictly necessary ... but I like it! @xabbuh what do you think about this proposal? Thanks!

@ScullWM
Copy link
Contributor Author

ScullWM commented May 31, 2018

Thanks @javiereguiluz
I've seen this in some other YAML configuration snippets (https://github.com/symfony/symfony-docs/blob/master/service_container/3.3-di-changes.rst#the-new-default-servicesyaml-file)

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jun 1, 2018
@javiereguiluz
Copy link
Member

Thomas, thanks for helping us improve this. I've merged in 3.4 (in theory 2.8 could also be possible, but there are too many merge conflicts). I see that it's your first Symfony Docs contribution too, so congrats on it!

javiereguiluz added a commit that referenced this pull request Jun 1, 2018
@javiereguiluz
minor #9858 Update tags declaration in yaml format (ScullWM)
940ad6c 
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9858).

Discussion
----------

Update tags declaration in yaml format

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

1c6029a Update tags declaration in yaml format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ScullWM @javiereguiluz @carsonbot