Use the new Security helper in some code examples #9847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
May 28, 2018
| $impersonatorUser = $role->getSource()->getUser(); | ||
| break; | ||
| if ($this->security->isGranted('ROLE_PREVIOUS_ADMIN')) { | ||
| foreach ($this->security->getToken()->getRoles() as $role) { |
There was a problem hiding this comment.
like $this->security->getUser() shouldn't it hide ->getToken() to access to ->getRoles() directly?
There was a problem hiding this comment.
I'm sorry but I don't understand this comment.
There was a problem hiding this comment.
I expected like $this->security->getUser() a shortcut like $this->security->getRoles() instead of $this->security->getToken()->getRoles() but I've seen that this has not been added to this helper. Nevermind, anyway this only documents what is implemented.
javiereguiluz
added a commit
that referenced
this pull request
Jun 1, 2018
…eguiluz) This PR was squashed before being merged into the 3.4 branch (closes #9847). Discussion ---------- Use the new Security helper in some code examples This fixes #8437 replacing `use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;` by `use Symfony\Component\Security\Core\Security;` when possible. Also, replace `use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;` by `use Symfony\Component\Security\Core\Security;` when possible. Commits ------- df21fd8 Use the new Security helper in some code examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8437 replacing
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;byuse Symfony\Component\Security\Core\Security;when possible.Also, replace
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;byuse Symfony\Component\Security\Core\Security;when possible.