Added docs for Symfony Polyfill components #9846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think a single page for every polyfill is a good idea as it'll create many almost similar files without good overview. What about a single package (e.g. Polyfill(s)) with one single usage instruction and an overview of all polyfill packages with the php functions they provide? |
|
@wouterj but that would result in a huge single-page documentation (and we plan to keep adding polyfills, so it will become bigger and bigger). Wouldn't that be a problem? |
|
I've added some more docs (all except the |
|
I'm merging this "as is" and if we think it's too much when it's published on the website, we can reword, merge, etc. |
javiereguiluz
added a commit
that referenced
this pull request
May 31, 2018
This PR was squashed before being merged into the 2.8 branch (closes #9846). Discussion ---------- Added docs for Symfony Polyfill components This fixes #6052 but before completing it, I'd like to ask @wouterj @xabbuh and @nicolas-grekas if you like this proposal or if you expect something different for these components docs. Thanks! Commits ------- 8c04898 Added docs for Symfony Polyfill components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6052 but before completing it, I'd like to ask @wouterj @xabbuh and @nicolas-grekas if you like this proposal or if you expect something different for these components docs. Thanks!