Skip to content

Corrected titles of test tools and use safe url for phpspec #9826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 26, 2018

Just another small improvement 😃

@javiereguiluz
Copy link
Member

I do appreciate this kind of fixes because it's important to display the right name.

I was curious about "phpspec" so I checked their website. I saw that they call themselves phpspec (all lowercased). See https://www.phpspec.net/en/stable/manual/introduction.html However, on Twitter they call themselves PhpSpec See https://twitter.com/phpspec So, what can we do here?

@lex111
Copy link
Contributor Author

lex111 commented May 27, 2018

However on the page of their organization, it's written - PHPSpec Framework, let's use this name, in the end it most corresponds to the language (PHP is an abbreviation).

@javiereguiluz
Copy link
Member

Thanks for the insights! Let's merge it (on 2.8 branch, the oldest maintained branch now that 2.7 is deprecated)

javiereguiluz added a commit that referenced this pull request May 27, 2018
…ec (lex111)

This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #9826).

Discussion
----------

Corrected titles of test tools and use safe url for phpspec

Just another small improvement 😃

Commits
-------

428120a Corrected titles of test tools and use safe url for phpspec
@lex111
Copy link
Contributor Author

lex111 commented May 27, 2018

Oh, again I made a mistake with the branch, because of what the commit will not be under my authorship, not that it worries me, but it's a little kind of frustrating.

@xabbuh
Copy link
Member

xabbuh commented Jun 12, 2018

@lex111 no need to worry, it's still your authorship (see 428120a) :)

@javiereguiluz
Copy link
Member

@lex111 don't worry about the branch issue. Even if you target the right branch, the result will be the same. Because of the merging process of Symfony (both docs and code) each PR results in two commits: one with your authorship and another one for the merger.

You can see this in action here: https://github.com/symfony/symfony-docs/commits/master?after=3235d06602938d7b8887d9907ef6b258539b8170+139

merge

@lex111
Copy link
Contributor Author

lex111 commented Jun 12, 2018

@xabbuh @javiereguiluz I get it, thanks for the explanation! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants