Add URL-encoding notice #9824
Merged
Add URL-encoding notice #9824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've had trouble connecting to Amazon SES via recommended method. I kept getting: > Exception occurred while flushing email queue: Failed to authenticate on SMTP server with username "***" I've traced it to "+" sign in the password that Amazon SES automatically assigned to my SMTP credentials. I had a hunch that special characters might be a problem and was thinking along the lines of wrapping the whole MAILER_URL value in single quotes. Then I ran into https://stackoverflow.com/a/50498999/1419874 that solved the issue for me too. Since the OP lost 3hrs and myself almost an hour, I think URL encoding might not be so obvious. Hence I propose this change. I've intentionally put it at the top, since I think it applies to any method that has special characters in username/password, not just Amazon SES.
|
@nebkam thanks a lot for this! I'm sorry this made you lose some time. Let's reword this to show it more clearly to the readers. |
|
Thanks @nebkam. |
javiereguiluz
added a commit
that referenced
this pull request
May 27, 2018
This PR was merged into the 4.0 branch. Discussion ---------- Add URL-encoding notice I've had trouble connecting to Amazon SES via recommended method. I kept getting: > Exception occurred while flushing email queue: Failed to authenticate on SMTP server with username "***" I've traced it to "+" sign in the password that Amazon SES automatically assigned to my SMTP credentials. I had a hunch that special characters might be a problem and was thinking along the lines of wrapping the whole MAILER_URL value in single quotes. Then I ran into https://stackoverflow.com/a/50498999/1419874 that solved the issue for me too. Since the OP lost 3hrs and myself almost an hour, I think URL encoding might not be so obvious. Hence I propose this change. I've intentionally put it at the top, since I think it applies to any method that has special characters in username/password, not just Amazon SES. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 7f72a6f Reword 61a69ac Add URL-encoding notice
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had trouble connecting to Amazon SES via recommended method.
I kept getting: