Update 3.3-di-changes.rst #9813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From symfony 3.4 aliases are not public by default https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default so docs are not in synch with this change. Maybe would be better to highlight this also in symfony 3.3 docs as a notice? Moreover this seems to me nearly a BC.
|
Thanks Samuele. |
javiereguiluz
added a commit
that referenced
this pull request
May 27, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Update 3.3-di-changes.rst From symfony 3.4 aliases are not public by default https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default so docs are not in synch with this change. Maybe would be better to highlight this also in symfony 3.3 docs as a notice? Commits ------- ec76e34 Minor tweak 870e005 Update 3.3-di-changes.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From symfony 3.4 aliases are not public by default https://symfony.com/blog/new-in-symfony-3-4-services-are-private-by-default so docs are not in synch with this change.
Maybe would be better to highlight this also in symfony 3.3 docs as a notice?