Skip to content

added initial_place entry #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018
Merged

added initial_place entry #9786

merged 1 commit into from
May 23, 2018

Conversation

stoccc
Copy link
Contributor

@stoccc stoccc commented May 16, 2018

I added the value for the config entry initial_place.

This clarifies the config of the workflow and eliminates ambiguities about which is the initial place of the workflow - doing some tests, it seems that the first place defined in the list will be the initial place when the marking is null.

I added the value for the config entry initial_place.

This clarifies the config of the workflow and eliminates ambiguities about which is the initial place of the workflow - doing some tests, it seems that the first place defined in the list will be the initial place when the marking is null.
@xabbuh xabbuh added this to the 3.4 milestone May 17, 2018
@xabbuh
Copy link
Member

xabbuh commented May 17, 2018

If there is no initial marking, the behaviour will be dependent on the underlying object. IMO we can make this change to make the workflow more clear.

@lyrixx What do you think?

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 👍

@javiereguiluz
Copy link
Member

Thanks @stoccc.

@javiereguiluz javiereguiluz merged commit da95046 into symfony:3.4 May 23, 2018
javiereguiluz added a commit that referenced this pull request May 23, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

added initial_place entry

I added the value for the config entry initial_place.

This clarifies the config of the workflow and eliminates ambiguities about which is the initial place of the workflow - doing some tests, it seems that the first place defined in the list will be the initial place when the marking is null.

Commits
-------

da95046 added initial_place entry
@stoccc stoccc deleted the patch-4 branch May 24, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants