Skip to content

[Console] Fix SymfonyStyle::ask usage #9741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018
Merged

[Console] Fix SymfonyStyle::ask usage #9741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38bcfcb
[Console] Fix SymfonyStyle::ask usage
liviubalan May 7, 2018
9bb23e1
Use is_numeric()
javiereguiluz May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/style.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ User Input Methods
the third argument::

$io->ask('Number of workers to start', 1, function ($number) {
if (!is_integer($number)) {
if (!ctype_digit($number)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail if the user types nothing and the default value (which actually is an integer) is used? What about combining both checks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use http://php.net/is_numeric first and then cast to int?

throw new \RuntimeException('You must type an integer.');
}

Expand Down