Skip to content

Documentation about authentication for multiple firewalls under same context #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Documentation about authentication for multiple firewalls under same context #9733

wants to merge 2 commits into from

Conversation

koutsoumposval
Copy link

Added documentation about authentication for multiple firewalls under the same firewall context

@javiereguiluz javiereguiluz added this to the 2.7 milestone May 21, 2018
@javiereguiluz
Copy link
Member

@koutsoumposval thanks a lot for this contribution! I'm proposing a reword to update the existing example with your own example and add some code comments to make the overall article more concise.

@koutsoumposval
Copy link
Author

Makes sense @javiereguiluz! Let's merge it this way

@koutsoumposval
Copy link
Author

For future reference, this example is not working when logout_on_user_change = true in firewall configuration, but I am not sure if my SF security configuration is causing it or it is also caused by the SF default security configuration. That is why I am not including it as a comment in the PR.

@javiereguiluz
Copy link
Member

@koutsoumposval this is now merged ... so congrats on your first Symfony Docs contribution! Regarding the question about "logout_on_user_change = true", please keep looking into it and if you think it's a Symfony bug, please open an issue. Thanks!

javiereguiluz added a commit that referenced this pull request May 24, 2018
@javiereguiluz
minor #9733 Documentation about authentication for multiple firewalls…
9772551 
… under same context (Valantis Koutsoumpos, javiereguiluz)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #9733).

Discussion
----------

Documentation about authentication for multiple firewalls under same context

Added documentation about authentication for multiple firewalls under the same firewall context

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

eae4a3c Reword
d430972 Added documentation about authentication for multiple firewalls under the same firewall context
@javiereguiluz
Copy link
Member

By the way, this was merged on 2.7 branch and later, we'll automatically merge it in all the other maintained branches up to master.

@koutsoumposval
Copy link
Author

I'll keep looking into it @javiereguiluz and do all needed actions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@koutsoumposval @javiereguiluz @carsonbot