Skip to content

Documented HTTP caching and user sessions #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Apr 23, 2018

As promised in #9647.

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 23, 2018

@Toflar thanks a lot for this contribution! It's perfectly explained and it's easy to follow.

However, I made some rewords to make the explanations more concise. We do this routinely not only for the readers, but also for us, to make contents easier to maintain. Thanks!

@Toflar
Copy link
Contributor Author

Toflar commented Apr 23, 2018

It's perfectly fine. Rewording by the same people makes sure the readers have a consistent reading experience, it's perfect! Thank you very much!

@Toflar
Copy link
Contributor Author

Toflar commented Apr 24, 2018

BTW: What's the policy to use .. versionadded:: 4.1? Should we maybe also use that here?

@javiereguiluz
Copy link
Member

We include a .. versionadded:: for all new features and also for deprecations. And yes, we should use it here and that's why I included at the end, just after the code example that uses the new feature 😄

@Toflar
Copy link
Contributor Author

Toflar commented Apr 24, 2018

Oh man, what a morning. I miss everything 🤣 Sorry, Javier! And thanks for the patience 😃

@javiereguiluz
Copy link
Member

And it's merged!! Thanks Yanick!

@javiereguiluz javiereguiluz merged commit ecb0ac4 into symfony:master Apr 24, 2018
javiereguiluz added a commit that referenced this pull request Apr 24, 2018
…eguiluz)

This PR was merged into the master branch.

Discussion
----------

Documented HTTP caching and user sessions

As promised in #9647.

Commits
-------

ecb0ac4 Minor reword to make it more concise
9b37b0e Documented HTTP caching and user sessions
@Toflar Toflar deleted the http-caching-and-sessions branch April 24, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants