FIX : accessing global variable tokenStorage #9626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
bug
HttpFoundation
Status: Reviewed
and removed
Status: Needs Review
labels
Global variable tokenStorage needs '$this->' to get accessed correctly
|
Well spotted! Thanks @luxferoo. We merged it on 3.4 branch because that's the oldest maintained branch that contains the bug and then we'll merge it up into the other branches. Congrats on your first Symfony Docs contribution too! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 20, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #9626). Discussion ---------- FIX : accessing global variable tokenStorage Global variable tokenStorage needs '$this->' to get accessed correctly Commits ------- 42d7bfd FIX : accessing global variable tokenStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global variable tokenStorage needs '$this->' to get accessed correctly