Skip to content

flex loading files in routes and the route definition without prefix… #9609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mackou
Copy link

@mackou mackou commented Apr 16, 2018

… wins over the route definition with a prefix. #9608

see issue #9608
#9608

@tomtomau
Copy link
Contributor

Can I recommend you elaborate on this further in the documentation? I couldn't properly grasp what the documentation meant until I read @stof's quote.

I would recommend explaining that the kernel autoloads all yaml files within routes.yaml and takes precedence over your definition etc. IMO it's a significant enough caveat that it wouldn't hurt to chuck it in a warning/caution block.

@xabbuh
Copy link
Member

xabbuh commented Apr 23, 2018

I think we should make that addition a caution block which explains that you need to be careful if routes overlap each other because the order in which they are loaded is important.

@wouterj
Copy link
Member

wouterj commented May 5, 2018

Hi @mackou! Thanks for starting the issue + PR round for this scenario, which led to interesting information about how routes are loaded in Flex!

The discussion in symfony/symfony#26949 led to another doc PR that documents this whole route loading logic in a more complete way: #9523 As that one is merged, I don't think we need to merge this one anymore.

Still thanks for starting this, I hope to see you back with other great contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants