class attribute still needed in some cases #9592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right about this. thanks for fixing it! However, I was checking the source code of Twig extensions (e.g. https://github.com/twigphp/Twig-extensions/blob/master/src/IntlExtension.php) and I saw that it added PHP namespaces in addition to the legacy PHP class names (the same that Twig did a while ago). So maybe a better solution could be to not add the services:
- Twig_Extensions_Extension_Intl:
+ Twig\Extensions\IntlExtension:
- class: Twig_Extensions_Extension_Intl
tags: [twig.extension] |
|
I did not know about that, thanks. I updated PR accordingly |
javiereguiluz
added
Status: Reviewed
and removed
Waiting feedback
Status: Needs Review
labels
|
It's merged now! @florian987 congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 19, 2018
This PR was squashed before being merged into the 3.4 branch (closes #9592). Discussion ---------- class attribute still needed in some cases The class attribute is still needed for non namespaced classes like Twig_Extensions_Extension_Intl <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- cb0ee3b class attribute still needed in some cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class attribute is still needed for non namespaced classes like Twig_Extensions_Extension_Intl