New section about JSON file manifest strategy #9548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtomau
suggested changes
Apr 19, 2018
There was a problem hiding this comment.
Looks great - thanks for your contribution!
Could you additionally update frontend/encore/versioning.rst to link through to this section to "read more" about asset versioning?
I know when I was getting started with Encore it would have been helpful 👍
components/asset.rst
Outdated
|
|
||
| Use the :class:`Symfony\\Component\\Asset\\VersionStrategy\\JsonManifestVersionStrategy` | ||
| to take advantage of the strategy used by popular tools such as `Webpack | ||
| <https://webpack.js.org/>`_, which generate a JSON file mapping all source file names to their corresponding output file. For example:: |
|
Thanks for your feedback! I will update the "learn more" section of Encore Component too! |
jeremyjumeau
commented
Apr 20, 2018
There was a problem hiding this comment.
@tomtomau do you think we should add a link to Encore Versioning documentation in the asset's doc "Learn More" section?
Learn more
----------
* :doc:`frontend/encore/versioning`
javiereguiluz
approved these changes
May 17, 2018
|
@jeremyjumeau thanks for this nice contribution! We merged it on 3.4 branch. |
javiereguiluz
added a commit
that referenced
this pull request
May 17, 2018
…au, javiereguiluz) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #9548). Discussion ---------- New section about JSON file manifest strategy @see https://symfony.com/blog/new-in-symfony-3-3-manifest-based-asset-versioning <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b8a67a4 Added a missing comma 3266473 Reword b33168a Link to the asset component documentation e0ed723 Fix typo 3ef51fc New section about JSON file manifest strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@see https://symfony.com/blog/new-in-symfony-3-3-manifest-based-asset-versioning